On Tue, 28 Jun 2011 17:31:11 +0200 Cyprien Nicolas <[email protected]> wrote:
> On 28/06/11 10:53, Michał Górny wrote: > > On Tue, 28 Jun 2011 10:48:48 +0200 Michał Górny <[email protected]> > > wrote: > > I'm a noob in Python, but I disagree with this patch. for two reasons: > > First, the -X option is already available, and controlled by > makelinks, so why not change the default value of makelinks to False? > > Second, after trying to understand the code, if your proposed patch is > applied, the makelinks variable become useless. So why not remove it > completly from the source? Is this variable still needed? > > There is some bunch of code starting at line 222 in the current HEAD, > which sets makelinks to False upon some conditions, does this need to > be refactored / removed somehow too? This patch is just the simplest approach to see if it works as expected. We'll prepare a better/more consistent patch when the concept itself is accepted. -- Best regards, Michał Górny
signature.asc
Description: PGP signature
