-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 22-09-2011 08:11, Michał Górny wrote: > On Thu, 22 Sep 2011 09:01:17 +0200 Ulrich Mueller <[email protected]> > wrote: > >>> Attaching fixed version of the last two patches, and a >>> complete eclass for convenience. >> >> Just a general comment: Is it really necessary to change all [[ >> -n ${foo} ]] and [[ -z ${foo} ]] conditionals to the more >> obscure [[ ${foo} ]] and [[ ! ${foo} ]]? >> >> The shortest possible form is not always the one that's best >> readable. > > The style change was approved by Donnie already.
You mean that Donnie agreed with the style change. It's not up to any individual developer to "approve" such a change for the entire tree. - -- Regards, Jorge Vicetto (jmbsvicetto) - jmbsvicetto at gentoo dot org Gentoo- forums / Userrel / Devrel / KDE / Elections / RelEng -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.18 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQIcBAEBAgAGBQJOexTUAAoJEC8ZTXQF1qEPMZ0QALNSTSCLwCKP9hd2BSt7HtP3 BzsJHr9Q+9+DpdwG9eRjbE0AnW1EbhpFmctPAnEszwC7I0NxID8vAsMw4HQS2MA8 wv2HKY14HYhSV9KBhHISn0i3tg8+LPwCpZJUYca4LWM+1o6brW/+MYEyzRBjWnMN ljVEfK+to94+UvsPZyjvd0jRp3MuGVoATyXEDwHo1pNFC89Fq03J2YSvP6lPYE1V J/Etw9PM5jJLWE7qQ8BlxHvf4FCWXZbAoOJ1kAFKLUp0v9AJeHssU84ZxZWDU/Rc NjAiscFDXfhldL/DYlXFtZe24nF2V9aJ8DNFk+639f+L45oky5WNupiyRLMyn9ut WAJAoPIoyQRccph5eAW2frrk7hUKhjsfS3uCDCB9otncQYpAFLK4X8USzRMEQlNV QBBODOwccb/9BbwK6WGTywJiamB36dR9YGtdD6h+gULytRP9+WCK2HYGhQOAxumE y+nVo4o5JAvHJ5W2IpCO611rbpyx/KXLGMu7my2OY06xrSsf1tU1DMEN+T3YtZ0s s7TQRvbobKYmi4RsbQ/3J6ept5KldLLuhi4B/l/Nst2Di9bMCQ0bCHKcObeKsir+ LOb7zdVMwVAvCK1DvnPgFKMyR5LCfcHvdy1tD6UxwYlNUcm6SNMytb1QET/B0k4n 6Yyi7UQgCXfYWP5KL7TX =4YOg -----END PGP SIGNATURE-----
