On Mon, 24 Oct 2011 03:42:24 +0000 Nathan Phillip Brink <[email protected]> wrote:
> On Sun, Oct 23, 2011 at 08:20:37PM +0200, Micha?? G??rny wrote: > > --- > > scons-utils.eclass | 33 +++++++++++++++++++++++++-------- > > 1 files changed, 25 insertions(+), 8 deletions(-) > ... > > +# @ECLASS-VARIABLE: myesconsargs > > +# @DEFAULT_UNSET > > +# @DESCRIPTION: > > +# List of package-specific options to pass to all SCons calls. > > Supposed to be +# set in src_configure(). > > Shouldn't this variable be named MYESCONSARGS since it is being > introduced into the global scope? I can't deny that but I'd like to keep it consistent with cmake-utils and autotools-utils. Alternate approach would be to make it local to src_configure() and add scons-utils_src_configure() which would export it under internal name but I don't think that's really worth the effort. -- Best regards, Michał Górny
signature.asc
Description: PGP signature
