-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 On 04/11/11 11:11 AM, Fabio Erculiani wrote: > On Fri, Nov 4, 2011 at 3:46 PM, Mike Gilbert <[email protected]> wrote: >> >> It is good that we warn users about this when they install the package, >> but I don't think the ebuild should die. > > I've always found ebuilds dying at kernel config checks really annoying. > Checking kernel features at build time (if we die) is broken and > should be banned IMO: > > 1) in case of packages not needing kernel headers for building (but > just checking for a feature) > a) this breaks the compilation inside chroots on build servers where > the goal is to just build the package (hint: binpkgs) > b) it is anyway unable to reliably check if the feature is actually > available or not (/proc/config.gz might be unavailable, as well as > kernel sources or headers)
As i think has already been mentioned, when building binpkgs or building for other systems, since the idea here is to ensure build-time requirements are met, things should be OK as long as you have a configured kernel for the target in place as well. And you probably should; if you're building packages for target systems you might as well configure and/or build their kernels too. Also as was mentioned, /proc/config.gz would never be appropriate in these cases since the running kernel probably has nothing to do with the target system's kernel. > > 2) in case of packages needing kernel headers (or sources) for building > a) doing the check in pkg_setup() breaks binpkgs support (the check > becomes part of a build time task, and not install time) .. so you're recommending the check be moved to pkg_preinst() ? Or perhaps duplicated into both pkg_setup/pkg_pretend and pkg_preinst ? That would be doable, wouldn't it? -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.17 (GNU/Linux) iF4EAREIAAYFAk60BMQACgkQAJxUfCtlWe17qwEAhh2udNzptIJZHeEyh8DJhTj3 HLbC/ZpIJUQTbpHueOEBAITcA3DasGAQIdSWGvn7E2xwYMFTS+U0UyDWJCesv5xR =U+gT -----END PGP SIGNATURE-----
