>>>>> On Fri, 6 Jan 2012, Michał Górny wrote:

>       if [[ ${DOCS} ]]; then
>               dodoc "${DOCS[@]}" || die "dodoc failed"
> +     else
> +             local f
> +             # same list as in PMS
> +             for f in README* ChangeLog AUTHORS NEWS TODO CHANGES \
> +                             THANKS BUGS FAQ CREDITS CHANGELOG; do
> +                     if [[ -s ${f} ]]; then
> +                             dodoc "${f}" || die "(default) dodoc ${f} 
> failed"
> +                     fi
> +             done
>       fi

Why only "similarly to EAPI 4" and not identical with it? The latter
would follow the principle of least surprise.

Taken from _eapi4_src_install() in phase-helpers.sh:

    if ! declare -p DOCS &>/dev/null ; then
        local d
        for d in README* ChangeLog AUTHORS NEWS TODO CHANGES \
            THANKS BUGS FAQ CREDITS CHANGELOG ; do
            [[ -s "${d}" ]] && dodoc "${d}"
        done
    elif [[ $(declare -p DOCS) == "declare -a "* ]] ; then
        dodoc "${DOCS[@]}"
    else
        dodoc ${DOCS}
    fi

Ulrich

Reply via email to