>>>>> On Wed, 18 Jan 2012, Mike Frysinger wrote:

>> CDROM_DISABLE_PROPERTIES=1
>> inherit [...] cdrom
>> 
>> IUSE="cdinstall"
>> PROPERTIES="cdinstall? ( interactive )"
>> 
>> It would be required for 7 out of the 36 packages that use cdrom
>> functions.

> since USE=cdinstall has been our standard, then perhaps we should codify that
> in the eclass.  are there ebuilds that set CDROM_DISABLE_PROPERTIES and don't
> have IUSE=cdinstall ?

Indeed, all of them have PROPERTIES="cdinstall? ( interactive )".

> ebuild:
> CDROM_OPTIONAL="yes"
> inherit cdrom

> eclass:
> if [[ ${CDROM_OPTIONAL} == "yes" ]] ; then
>       PROPERTIES="cdinstall? ( interactive )"
> else
>       PROPERTIES="interactive"
> fi
> IUSE="cdinstall"

Looks good, except that I would move the IUSE line into the "then"
clause.

Ulrich

Reply via email to