On Wednesday 18 January 2012 08:39:04 Michał Górny wrote:
> On Wed, 18 Jan 2012 06:22:24 -0500 Mike Frysinger wrote:
> > > >         # now we see if the user gave use CD_ROOT ...
> > > >         # if they did, let's just believe them that it's correct
> > > >         if [[ -n ${CD_ROOT}${CD_ROOT_1} ]] ; then
> > > >         
> > > >                 local var=
> > > >                 cdcnt=0
> > > >                 while [[ ${cdcnt} -lt ${CDROM_TOTAL_CDS} ]] ; do
> > > >                         ((++cdcnt))
> > > >                         var="CD_ROOT_${cdcnt}"
> > > >                         [[ -z ${!var} ]] && var="CD_ROOT"
> > > >                         if [[ -z ${!var} ]] ; then
> > > >                                 eerror "You must either use just
> > > > the CD_ROOT" eerror "or specify ALL the CD_ROOT_X variables."
> > > >                                 eerror "In this case, you will
> > > > need" \ "${CDROM_TOTAL_CDS} CD_ROOT_X
> > > > variables." die "could not locate CD_ROOT_${cdcnt}"
> > > >                         fi
> > > >                 done
> > > >                 export CDROM_ROOT=${CD_ROOT_1:-${CD_ROOT}}
> > > >                 einfo "Found CD #${CDROM_CURRENT_CD} root at
> > > > ${CDROM_ROOT}"
> > > 
> > > #1. You are using 1 in variable calls, I don't see a reason to use
> > > longer ${CDROM_CURRENT_CD} in this one output case.
> > 
> > i don't know what you mean
> 
> einfo "Found CD #1 root at ..."

*shrug* i preferred the # in the output
-mike

Attachment: signature.asc
Description: This is a digitally signed message part.

Reply via email to