On Fri, 30 Mar 2012 13:59:10 +0200 ""Paweł Hajdan, Jr."" <phajdan...@gentoo.org> wrote:
> > echo 'import Distribution.Simple; main = defaultMainWithHooks
> > defaultUserHooks' \
> > > $setupdir/Setup.hs
> > }
>
> I think there should be || die after echo, to catch out-of-disk-space
> problems.
Ok :]
> > # GHC 6.4 has a bug in get/setPermission and Cabal 1.1.1 has
> > # no workaround.
> > # set the +x permission on executables
> > if [[ -d "${ED}/usr/bin" ]] ; then
> > chmod +x "${ED}/usr/bin/"*
> > fi
> > # TODO: do we still need this?
> > }
>
> I think there should be || die after chmod.
I'll remove the whole block.
> > if [[ -z "${CABAL_HAS_BINARIES}" ]] && [[ -z "${CABAL_HAS_LIBRARIES}"
> > ]]; then
> > eerror "QA: Neither bin nor lib are in CABAL_FEATURES."
>
> Shouldn't this be eqawarn?
>
> > fi
> > if [[ -n "${CABAL_UNKNOWN}" ]]; then
> > ewarn "Unknown entry in CABAL_FEATURES: ${CABAL_UNKNOWN}"
>
> Shouldn't this be eqawarn?
'eqawarn' sounds fine here. I'll push the changes to overlay first and then to
the gx86.
Thanks for sharing!
--
Sergei
signature.asc
Description: PGP signature
