On Monday 07 of May 2012 10:32:45 Samuli Suominen wrote: > On 05/07/2012 02:24 AM, Ulrich Mueller wrote: > >>>> Therefore I suggest we move this example a bit down in skel.ebuild > >>>> as it's more logical to continue with new lines instead of applying > >>>> in-between > >>>> > >>>> Any objections? > >>> > >>> Yes. Please leave it as it is. > >> > >> Yeah, I will if someone has a (good) argument for doing so. > > > > RESTRICT and PROPERTIES are on a single line and it's natural to add > > them to the second group of such variables, namely LICENSE, SLOT, > > KEYWORDS, and IUSE. > > > > Whereas DEPEND and RDEPEND typically extend over several lines; > > sometimes they are quite long. So, a RESTRICT line placed after > > *DEPEND will be much more easily missed than in its current place.
And I use quite different 'rule' where to place variables: - to separate frequently changed ones (KEYWORDS, IUSE) with rather invariant ones (SLOT, LICENSE) Rationale: It generates smaller diffs (and less conflicts when doing semi-automatic merges of ebuild changes between branches as those are likely both IUSE and KEYWORDS changes, KEYWORDS changes are rarely desired to be included in merge, if IUSE is just below the line with KEYWORDS, KEYWORD change will be accidentally taken in) -- regards MM
signature.asc
Description: This is a digitally signed message part.
