On Wednesday 23 May 2012 21:04:42 hasufell wrote:
> # @FUNCTION: _iconins
> # @DESCRIPTION:
> # function for use in doicon and newicon

mark it @INTERNAL

>                       if [[ -z $size ]] ; then

${size}

>                       if [[ $function == doicon ]] ; then

${function}

>       if [[ $function == newicon ]] ; then

${function}

> doicon() {
>       local function=$FUNCNAME
>       _iconins "$@"

passing the funcname in this way is kind of ugly.  you could do:
        _iconins ${FUNCNAME} "$@"

and then at the top of _iconins:
        local funcname=$1; shift

i guess if we all agree this complication is useful, then fix the nits and 
let's merge it
-mike

Attachment: signature.asc
Description: This is a digitally signed message part.

Reply via email to