On 19 July 2012 21:14, Ralph Sennhauser <[email protected]> wrote: > > I assume the P in PLOCALS stands for package. Not that obvious if you > ask me. L10N_LOCALS would at least tell me which eclass this variable > belongs to.
Yes, as P is widely used to refer to the package. I wanted something to
reflect that these are the locales offered by the package.
> Instead of using LINGUAS you should make use of the use function to get
> your cross sections. ie.
>
> for locale in ${PLOCALES}; do
> if use linguas_${locale}; then
> enabled_locales+=" ${locale}"
> else
> disabled_locales+=" ${locale}"
> fi
> done
>
> First, this is guaranteed by PMS and so independent of package manager
> and second, you do not have to care about locales in LINGUAS which are
> invalid for the package. Could be that Portage re-exports a sanitized
> LINGUAS tough, but I doubt it.
This is a good suggestion, as it makes things simpler and more along
expected lines.
I got a few more suggestions on IRC, and I have updated the eclass
accordingly. Please check the attached new version, also available at
https://gitorious.org/gentoo-qt/qt/blobs/master/eclass/l10n.eclass
--
Cheers,
Ben | yngwin
Gentoo developer
Gentoo Qt project lead, Gentoo Wiki admin
l10n.eclass
Description: Binary data
