On 07-08-2012 18:03:14 +0200, Torsten Veller wrote:
> * "Fabian Groffen (grobian)" <grob...@gentoo.org>:
> > grobian 12/08/07 15:21:54
> >
> > Modified: ChangeLog
> > Added: XML-Parser-2.410.0-r1.ebuild
> > Log:
> > Fix expat detection for FreeBSD that silently went unnoticed.
>
> The following single quotes were dropped:
>
> -myconf="EXPATLIBPATH='${EPREFIX}/usr/$(get_libdir)'
> EXPATINCPATH='${EPREFIX}/usr/include'"
> +myconf="EXPATLIBPATH=${EPREFIX}/usr/$(get_libdir)
> EXPATINCPATH=${EPREFIX}/usr/include"
>
> Sorry, I don't understand the problem. Is it a general problem with
> the single quote or a special FreeBSD problem?
I've only observed it happening on FreeBSD indeed.
> I think we should convert all myconf strings to arrays:
> myconf=( EXPATLIBPATH="${EPREFIX}"/usr/$(get_libdir)
> EXPATINCPATH="${EPREFIX}"/usr/include )
I don't understand enough of the Makefile.PL thing to tell why the
quotes work on Darwin, Solaris, but not FreeBSD 9.1-BETA1. I do know
that EPREFIX cannot contain spaces though, hence I applied the fix as
committed. If the array approach works with the eclass, then that'll be
certainly cleaner.
--
Fabian Groffen
Gentoo on a different level
signature.asc
Description: Digital signature
