-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 09/14/2012 11:51 AM, Ulrich Mueller wrote:
>>>>>> On Fri, 14 Sep 2012, Rick "Zero Chaos" Farina wrote:
>
>>> addwrite /
>> Am I reading this wrong, or is "addwrite /" being more than just a
>> little lazy? I know this isn't part of your change set but it has
>> always bothered me that it needs to unlocking writing on the whole
>> filesystem to save something in distdir.
>
> EBZR_STORE_DIR may be redefined, so you cannot be sure that it's below
> DISTDIR. Also, it's not known how many of its path components already
> exist. I'm not sure if it would be worth the effort to compute a more
> accurate argument for addwrite. (Almost all live eclasses do that
> "addwrite /", by the way.)
I didn't mean to pick on bzr.eclass, I think it's always wrong to do
this. And you picked out the exact reasoning I did "I'm not sure if it
would be worth the effort to compute a more accurate argument for
addwrite." I think it is worth the effort to do it right. I mean
(purposeful exaggeration here) we could save the addwrite entirely by
just "killall sandbox" or we could prevent from reoccurring by
restricting the sandbox feature. Any time you do "addwrite /" you
completely defeat the entire purpose of sandbox. It's not write (get it?).
I'm not saying this is an emergency nor should it hold back any changes
you need to make to argue with me about it. However, if you were to do
it right that would be cool. Otherwise we could all start fixing our
sandbox issues by just doing "addwrite /" at the top of all ebuilds.
Thanks,
Zero
>
>>> mkdir -p "${EBZR_STORE_DIR}" \
>>> || die "${EBZR}: can't mkdir ${EBZR_STORE_DIR}"
>
> Ulrich
>
>
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.19 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://www.enigmail.net/
iQIcBAEBAgAGBQJQU1djAAoJEKXdFCfdEflKlecP/jVjGN76yb/VJ+5/O75lwwhf
7p7pppohVw4gfaiiHOz0uamu37RPPqlmc+LV4TgUxQ+n6VMkdrXG7tU0TTewYEEw
mTorfsF5i2aFXJXMRIT5Xz+P+iEx9m4bhbKuxjL17DKs4F9jKToao/1ix2lhNKZX
ClnAp+qgKNN2fj/1vnBNkGSIfWF9EEkpfCqC0d2kXLADXJCNqaOmUmVI9+5XXAFw
7X+DW1JMRgg64yQ78bztHmmKqQ211WK3JqqmZPxb4bms5RQPCILBjc+OQ97KKwBW
woXfV+gZInTrfvgADEFCLeDSKuEojqriu7UrXCBkwNkDEzVdsLWXD25lUzo2bmPP
nuUOjBsIiFJAt8UdpAn+y7hDVy5BfClE24FxVSk+ydthlkGNW6T0tMEikBhserJ5
bi0qF7qOp6Wu+OVS0a+de2ptcy6z/AVm8ziDSY70mX32GqW0APkft+yvzluibpXZ
a37c+zYoytWb1GK5ijC8I29xi5GDilouaX+DMVz2woZChEhYuZ8ElKpHzHgI1HZs
dZirnsFjZt4jBBk2iB8NUHyccze4XpmSnwd75w0ltNaAs1IhTATxIbbkRokQJ0F7
FteSyd/0jzvRGIIgpTpJBtga4UMkRZxpnG/2OIKn0hy+4tvotwUknwzWDGEdCKQq
5k4jnZXA364VLoeYOXeK
=0AWM
-----END PGP SIGNATURE-----
