-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 09/14/2012 04:56 PM, Ciaran McCreesh wrote: > On Fri, 14 Sep 2012 16:51:54 -0400 > "Rick \"Zero_Chaos\" Farina" <[email protected]> wrote: >> I have a personal vendetta on this subject. Several eclasses set a >> completely worthless description (and even more set a mostly worthless >> DESCRIPTION) which ends up contaminating the DESCRIPTION for an ebuild >> when inherit is done after DESCRIPTION is set. > > http://article.gmane.org/gmane.linux.gentoo.devel/78813/ > >> I realize that most of you will find this a little pedantic, however, >> I find that needing to move my DESCRIPTION to below the inherit often >> severely affects the readability of the ebuild, and all to avoid a >> completely (or nearly) worthless DESCRIPTION from contaminating my >> environment. > > You want your inherit line to be as near as the top as possible. The > only things you should have before the inherit line are EAPI and any > variables used by eclasses to determine behaviour. > > I have a nasty habit of writing ebuilds to be both live and versioned which requires me to test ${PV} then set things like inherit VCS, SRC-URI, and KEYWORDS below. The large if block looks better in my opinion below the settings which are the same for all versions, rather than in the middle.
Yes, it's a readability issue, but the point is, this shouldn't be an issue at all. - -Zero -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://www.enigmail.net/ iQIcBAEBAgAGBQJQU58YAAoJEKXdFCfdEflKcicP/jXycBrtKT0E6WZCE2QTqtVR fTMsreFwfAx3MGoLTMNQ+t9dPI6EplhCb04YbIFzgwR27Qi4y5xDEveX21JiKH7Z CglVwlPZ7zQ3qcQGOW7ydrp8YAPw0pLQlZmr/pVd7RD2qWbT9KYuKNu+NON3igdn PcwZlppndxCS+Ny9UaIhBFeRZveKjvhzqDWoUhcMqnFtxQQ8KJijXLlhfKJ5yuQT 7QU5gE9VWGo30rnFmXwTzDG5fMAcp1j7m5/D9sf5nG9HtfHjuiP07KXD/DC6KdXD TPc2watS6T8a4iSZ+Jf4WP8FOu21JFJaYHgMwRY02XTaG8p0CXkO6z0gfVXWHi/f oOpU9Z6OZ+n2GyWyS1KFGAM5Hed4fM7RMMC1l+owHDh0aHBZy1cJfiyjcmSMSp35 Kx0bS4J2NkeYYox80oPbLpRcnBjGmcAif+Ch3Hb8VRc21SH2bLdApeMBaij5VQn/ zUeKSYYsUKh8xRQ0PLSMqPY0QOpNA7qBH6K9gRg5v4b2Y/ZZlXEYP/BptfIyNDiV SIDMPKBjXoDHmfPLEjz0Sf2i3EYon4oGvnl/YW6GDB7TvUufgPzMER9mw57wuqLa aj9gQjvGroxeVsZ6w9Y8w0oQZdjB7lzWxsEq1YPY58b5ngy7b8ocUNNLxBX/K+JY 9TomNP1ENsFjp39JLmA8 =50OQ -----END PGP SIGNATURE-----
