-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

> In my opinion, the text "# @DESCRIPTION" in an eclass is more than
> enough for readability, and setting DESCRIPTION only serves to
> contaminate the environment.  The is especially true for the following
> eclasses that set the DESCRIPTION from the subject:
> 
> ozzie eclass # grep 'DESCRIPTION="Based on the ' *.eclass
> cannadic.eclass:DESCRIPTION="Based on the $ECLASS eclass"
> confutils.eclass:DESCRIPTION="Based on the ${ECLASS} eclass"
> embassy.eclass:DESCRIPTION="Based on the $ECLASS eclass"
> eutils.eclass:DESCRIPTION="Based on the ${ECLASS} eclass"
> games.eclass:DESCRIPTION="Based on the ${ECLASS} eclass"
> gnatbuild.eclass:DESCRIPTION="Based on the ${ECLASS} eclass"
> gnuconfig.eclass:DESCRIPTION="Based on the ${ECLASS} eclass"
> libtool.eclass:DESCRIPTION="Based on the ${ECLASS} eclass"
> linux-mod.eclass:DESCRIPTION="Based on the $ECLASS eclass"
> nsplugins.eclass:DESCRIPTION="Based on the ${ECLASS} eclass"
> perl-module.eclass:DESCRIPTION="Based on the $ECLASS eclass"
> qmail.eclass:DESCRIPTION="Based on the ${ECLASS} eclass"
> toolchain-funcs.eclass:DESCRIPTION="Based on the ${ECLASS} eclass"
> 
> Although these are the ones that make me the most unhappy, I see no
> purpose for setting DESCRIPTION in any eclass as it really serves no
> purpose to source the eclass then source the ebuild 0.01s later and
> overwrite the DESCRIPTION.  Fixing this is not difficult, unlikely to
> affect anything, but will help avoid one tiny little annoyance that
> really looks like a relic from a time long long ago.

Right, it forbids repoman perform DESCRIPTION.missing check
and makes no sense in multiple inheritance case.

metadata/md5-cache:LANG=C fgrep -R "Based on " .
./sys-fs/sysfsutils-2.1.0:DESCRIPTION=System Utilities Based on Sysfs

None of in-tree users relies on the value. Thus you can wipe them while
nobody is watching :]
 
- -- 

  Sergei
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.19 (GNU/Linux)

iEYEARECAAYFAlBUQ/UACgkQcaHudmEf86qP3gCfftVveos4vrjFbUFSfqauVjm1
8c8AnRS8K4NG5NttW79RN5P9aYWY+Pju
=oDKV
-----END PGP SIGNATURE-----

Reply via email to