-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 On 07/10/12 02:56 PM, justin wrote: > On 10/7/12 8:19 PM, Chí-Thanh Christopher Nguyễn wrote: >> justin schrieb: >>> Hi, >>> >>> I want to add following change to fortran-2.eclass to achieve >>> more simpler usage. >>> >>> The patch will make the eclass depend on virtual/fortran so >>> that no manual addition is needed. Two exception are present, >>> a) the ebuild has the USE flag fortran, then we check for that, >>> or b) the FORTRAN_OPTIONAL variable is set, which leaves the >>> control to the ebuild (e.g. for cases like "lapack? ( >>> virtual/fortran )"). >> >> I suggest that you do something similar to the XORG_DRI variable >> in xorg-2.eclass. >> >> For example: FORTRAN_WANT_COMPILER=no would not add a >> virtual/fortran dependency FORTRAN_WANT_COMPILER=always would >> unconditionally depend on virtual/fortran >> FORTRAN_WANT_COMPILER=useflag would depend on useflag? ( >> virtual/fortran ) >> >> To avoid breaking existing packages, you could default to >> FORTRAN_WANT_COMPILER=fortran >> >> >> Best regards, Chí-Thanh Christopher Nguyễn >> >> > > Thanks for that suggestion. Please find the new version attached. > It basically follows what is done in the xorg-2.eclass. But we > allow a list of USE and don't allow a no, because the eclass itself > needs a fortran compiler. > > Thanks, justin
Looks better, but it would still be a good idea to have a possibility of setting FORTRAN_SUPPORT=no so that the eclass can be used without setting *DEPEND if a dev so desires. Right now it looks like FORTRAN_SUPPORT=no would result in DEPEND+="no? (virtual/fortran)" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (GNU/Linux) iF4EAREIAAYFAlB0IrMACgkQ2ugaI38ACPDCUAEAnMHvFfUv66mawyHc1cY7E6V3 de/3vSIcxPDjNuHLFlMA/Arhg6q0M2E3ECUZI83WYdNkKEQPSoD4uhqbD41X2VoO =8oKW -----END PGP SIGNATURE-----
