Le dimanche 24 mars 2013 à 20:20 -0400, Anthony G. Basile a écrit :
> Last call, does anyone have a problem with me updating the 
> pax-utils.eclass?  See Ref [3] above for the code.  I'll wait a couple 
> more days and then do it.

looks like last conditional branch for XT marking in pax-mark function
is not using the proper variables (pt_* instead ot xt_*).

The PAX_MARKINGS variable is not documented with eclass documentation
markup, it should at least get an "@INTERNAL" if this is not supposed to
be modified by eclass users.

_pax_list_files can receive documentation this way as well.

You should probably try to avoid mixing [[ ]] and [ ] in the eclass. [ ]
seems to be less used here so just have everything [[ ]] and drop the
useless quoting that came with [ ].

The rest looks fine.

-- 
Gilles Dartiguelongue <[email protected]>
Gentoo


Reply via email to