On Thu, 4 Apr 2013 10:07:06 +0200 Alexis Ballier <[email protected]> wrote:
> > It will be when there's a safe, public API for it. Right now, it's too
> > fragile.
>
> What exactly is the unsafe part of the API of this function ?
Well, the first thing was using $ABI directly, and I sent a patch for
that one already.
> You could
> very well make it functional by replacing MULTILIB_WRAPPED_HEADERS by
> arguments to the function and then it'd do what it's supposed to:
MULTILIB_WRAPPED_HEADERS will go public, I think. It's kind of nice to
have a single way to list them.
> wrap
> headers from its arguments into a multilib-safe header, move the unsafe
> headers to "${ED}"/tmp/multilib-include ; if this function is called,
> then multibuild_merge_root "${ED}"/tmp/multilib-include
> "${ED}"/usr/include
> _must_ be called at the end of src_install.
That part is fragile. I'd rather keep both steps encapsulated into two
functions. Especially that if we decide to support wrapping headers
outside /usr/include, the latter part would have to change.
--
Best regards,
Michał Górny
signature.asc
Description: PGP signature
