On 23/04/13 13:24, [email protected] wrote:
On 04/22/13 13:03, Tobias Klausmann wrote:
Hi!
Since we probably will have to fix the files coming out of
tarballs until the various upstreams have fixed them, I propose
running a PNG fixer during or after the install phase. Since
having pngcrush as dep for everything is not exactly lightweight,
I hacked together a PNG file fixer in pure(ish, see below)
Python:
No please, this real should stay really far from any package manager.
There are only two sane options:
1) fix libpng to be backward compatible
2) fix the package, and re-package / add a package for broken images
But please don't push on all our user systems something like this.
I appericiate the work done by Tobias utmost too but I have to agree
this is not something I want to see running automatically, or even
from within ebuilds.
Perhaps if upstream writes the minimalized C version with no
dependencies (or with only libpng dependency), we could add custom
fix_IDAT() function but even then I'd prefer we fix the packages instead
for SRC_URI=
Trying to push time for going through some of the packages at:
https://bugs.gentoo.org/show_bug.cgi?id=466190#c12
But help is needed and I bet some maintainers don't want others messing
with their packages in the first place.
The fix is the mentioned script OR pngcrush with USE="-system-libs" and
`pngcrush -fix -force`
http://git.schwarzvogel.de/?p=pngfixer;a=summary
Feel free to send patches
Note that all I wrote is the mind-numbingly simple pngfixer.py
script. The rest of the Python code is excised from PIL
(http://www.pythonware.com/products/pil/index.htm). I didn't have
to change anything there.
Also note that it is not _strictly_ pure Python I'm using: the
PIL components use Python's zlib.so and therefore are subject to
bugs in _that_ code.
Thanks for taking the time to write this it could be useful for
developers, but hopefully not as initially intended ;-)
+1+1+1
Thanks everyone,
- Samuli
