On Wed, 10 Jul 2013 22:25:50 +0200 Michał Górny <[email protected]> wrote:
> First of all: please wrap lines at 72 or 80 chars (even if the
> original eclass didn't do that).
>
> > if [[ "${CATEGORY}/${PN}" == "dev-python/twisted"* ]]; then
>
> I know you're not responsible for this but it seems wrong to have two
> different behaviors depending on PN. Is this used somewhere actually?
>
> > MY_PV="${MY_PV:-${PV}}"
> > MY_P="Twisted${MY_PACKAGE}-${MY_PV}"
> >
> > HOMEPAGE="http://www.twistedmatrix.com/";
> >
> > #SRC_URI="http://tmrc.mit.edu/mirror/twisted/${MY_PACKAGE}/$(get_version_component_range
> > 1-2 ${MY_PV})/${MY_P}.tar.bz2"
> > SRC_URI="http://twistedmatrix.com/Releases/${MY_PACKAGE}/$(get_version_component_range
> > 1-2 ${MY_PV})/${MY_P}.tar.bz2"
> >
> > LICENSE="MIT"
> > SLOT="0"
> > IUSE=""
> >
> > S="${WORKDIR}/${MY_P}"
> >
> > TWISTED_PLUGINS="${TWISTED_PLUGINS:-twisted.plugins}"
> > fi
That's what I thought when I saw that but I found that all the
dev-python/twisted-* packages are depending on this, so I went with it.
Now I'm thinking I could instead provide functions
twisted-r1_twisted_src_uri and twisted-r1_twisted_build_dir used as
SRC_URI="$(twisted-r1_twisted_src_uri)"
S="$(twisted-r1_twisted_build_dir)"
in the depender ebuilds.
signature.asc
Description: PGP signature
