-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
On 27/05/14 04:05 AM, Tom Wijsman wrote:
> On Tue, 27 May 2014 09:02:37 +0200 ""Paweł Hajdan, Jr.""
> <[email protected]> wrote:
>
>> I'm seriously considering just removing src_test to make the
>> package more maintainable (less code, less bugs filed, can focus
>> on things that *do* impact our users).
>>
>> If you decide to comment in favor of keeping src_test, please
>> consider volunteering to help us with the bugs.
>>
>> Feel free to suggest solutions that fall somewhere in between -
>> e.g. having src_test but not excluding any tests there and using
>> RESTRICT=test, so that someone who really wants to run the tests
>> FYI can do so.
>
> From a "test it for proper maintenance" point of view this makes
> some sense; however, from a "test it for proper usability" point of
> view this might become a bit questionable. Some users like to run
> these tests in order to know their browser will work on their
> system; perhaps even going further than that, it helps more users
> report bugs upstream.
>
> You could ask the users to file the tests related bugs upstream.
>
I don't know how much chromium is built and tested on lesser-used
arches (ie: arm, hppa, ia64, etc), but if there are dev's that try and
maintain these keywords that aren't in the team, it might be a good
idea to leave src_test in place, for them. However, you could always
wrap the actual contents of src_test with an "if [[ -n
${I_KNOW_WHAT_IM_DOING} ]] " or similar to keep tests from running
when the general userbase is trying to emerge it and happens to have
FEATURES="test" globally enabled..
An ewarn telling users that if they really do want to run these tests,
they can set the variable in make.conf or package.env or similar, and
also specifying that the tests are skipped due to only being useful
for upstream developers, may suffice... thoughts?
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.22 (GNU/Linux)
iF4EAREIAAYFAlOEnKkACgkQ2ugaI38ACPCBswD8CAx2cK2UH+/IzysGPiQjOEzF
n8Sxv3ZbtKh9+aBFv9IBAIMhfmgABYnUJlGUg/+mPHOY1d9XDRfM9WQskiJBc2Xk
=nWr/
-----END PGP SIGNATURE-----
