Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in x11-plugins/wmfishtime/files: wmfishtime-1.24-gtk.patch

[Jeroen Roovers]

On Sun, 22 Jun 2014 20:08:41 +0300
Samuli Suominen <ssuomi...@gentoo.org> wrote:

> LIBS = `$(PKG_CONFIG) gtk+-2.0 --libs` -lm -X11

No, it should be

LIBS = $(shell $(PKG_CONFIG) ...)

or PKG_CONFIG will be called every time LIBS is evaluated.

And while you're at it, why not call PKG_CONFIG on x11, too?

LIBS = $(shell $(PKG_CONFIG) --libs gtk+-2.0 x11) -lm


     jer