On 09/22/2014 08:40 AM, Ulrich Mueller wrote: >>>>>> On Mon, 22 Sep 2014, hasufell wrote: > >> Ulrich Mueller: >>> | • atomic commits (one logical change) >>> >>> A version bump plus cleaning up older ebuilds will be considered >>> one logical change, I suppose? > >> I'd consider it two logical changes (e.g. imagine a user complaining >> about ebuild removal... you cannot easily revert it if it's not a >> separate commit). But I don't have a strong opinion on that and I'm >> not sure if we can enforce commit rules in such fine-grained >> details, can we? > >> Do you think this should be added explicitly? > > It is a very common example that should be mentioned. >
Another example that just crossed my mind is ebuild bumps that also modify profiles/ (e.g. package.mask, because a dependency is also masked). I think I was initially assuming that it would be one commit since both things are related to the bump, but it also has advantages to split that up.
