On Wed, Jun 24, 2015 at 05:54:31PM +0200, Michał Górny wrote: > Dnia 2015-06-24, o godz. 15:38:34 > "William Hubbs (williamh)" <[email protected]> napisał(a):
*snip*
> > # @FUNCTION: _golang-build_setup
> > # @INTERNAL
> > # @DESCRIPTION:
> > # Make sure EGO_PN has a value.
> > _golang-build_setup() {
> > [ -z "${EGO_PN}" ] &&
>
> Please don't use 'unsafe' single brackets. Use bash's double brackets,
> i.e. [[ -z ${EGO_PN} ]].
Ok, this will be fixed.
> > golang-build_src_compile() {
> > debug-print-function ${FUNCNAME} "$@"
> >
> > _golang-build_setup
> > set -- env GOPATH="${WORKDIR}/${P}:${EPREFIX}/usr/lib/go-gentoo" \
> > go build -v -work -x "${EGO_PN}"
> > echo "$@"
>
> I suggest to push this to stderr, >&2.
Why? this is just printing the command before we run it. Do Make, etc
print this output to stderr?
>
> > "$@" || die
>
> And anyway, this looks to have a common, repeating part that sounds
> like a good candidate for separate emake-like function... ego? :D
Do you mean these lines:
echo "$@"
"$@" || die
William
signature.asc
Description: Digital signature
