On 10/03/2015 08:29 PM, Matthias Maier wrote:
> commit: a1015c1339068e9e942cb353f46a015b5612db1e
> Author: Matthias Maier <tamiko <AT> gentoo <DOT> org>
> AuthorDate: Sat Oct 3 18:26:45 2015 +0000
> Commit: Matthias Maier <tamiko <AT> gentoo <DOT> org>
> CommitDate: Sat Oct 3 18:29:30 2015 +0000
> URL: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=a1015c13
>
> app-emulation/libvirt: version bump to 1.2.20
>
> Package-Manager: portage-2.2.22
>
> app-emulation/libvirt/Manifest | 1 +
> app-emulation/libvirt/libvirt-1.2.20.ebuild | 492
> ++++++++++++++++++++++++++++
> 2 files changed, 493 insertions(+)
>
> diff --git a/app-emulation/libvirt/Manifest b/app-emulation/libvirt/Manifest
> index 816bdef..961bf34 100644
> --- a/app-emulation/libvirt/Manifest
> +++ b/app-emulation/libvirt/Manifest
[...]
> +
> + [[ -n ${BACKPORTS} ]] && \
> + EPATCH_FORCE=yes EPATCH_SUFFIX="patch" \
> + EPATCH_SOURCE="${WORKDIR}/patches" epatch
> +
little bash nitpicking... the '\' after '&&' is obsolete syntax
[...]
> +
> + # Tweak the init script
> + local avahi_init=
> + local iscsi_init=
> + local rbd_init=
> + local firewalld_init=
> + cp "${FILESDIR}/libvirtd.init-r15" "${S}/libvirtd.init"
missing || die
[...]
> + sed -e "s/USE_FLAG_FIREWALLD/${firewalld_init}/" -i "${S}/libvirtd.init"
> + sed -e "s/USE_FLAG_AVAHI/${avahi_init}/" -i "${S}/libvirtd.init"
> + sed -e "s/USE_FLAG_ISCSI/${iscsi_init}/" -i "${S}/libvirtd.init"
> + sed -e "s/USE_FLAG_RBD/${rbd_init}/" -i "${S}/libvirtd.init"
missing || die on all seds
> +
> + ## additional host drivers
> + myconf+=" $(use_with apparmor)"
> + myconf+=" $(use_with apparmor apparmor-profiles)"
> + myconf+=" $(use_with virt-network network)"
> + myconf+=" --with-storage-fs"
> + myconf+=" $(use_with lvm storage-lvm)"
> + myconf+=" $(use_with iscsi storage-iscsi)"
> + myconf+=" $(use_with parted storage-disk)"
> + mycond+=" $(use_with glusterfs)"
> + mycond+=" $(use_with glusterfs storage-gluster)"
> + myconf+=" $(use_with lvm storage-mpath)"
> + myconf+=" $(use_with rbd storage-rbd)"
> + myconf+=" $(use_with numa numactl)"
> + myconf+=" $(use_with numa numad)"
> + myconf+=" $(use_with selinux)"
> + myconf+=" $(use_with fuse)"
All this myconf stuff is very difficult to read, why not use a bash array?
In addition, it has two spelling errors "mycond", so gluterfs USE flag
is currently broken. Another reason to not use this form.
