On Fri, 9 Oct 2015 17:32:22 +0200
hasufell <hasuf...@gentoo.org> wrote:

> On 10/09/2015 01:17 PM, Alexis Ballier wrote:
> > commit:     5220bb29741e1685b42a6312c0b7bf2821672040
> > Author:     Alexis Ballier <aballier <AT> gentoo <DOT> org>
> > AuthorDate: Fri Oct  9 11:16:38 2015 +0000
> > Commit:     Alexis Ballier <aballier <AT> gentoo <DOT> org>
> > CommitDate: Fri Oct  9 11:16:52 2015 +0000
> > URL:
> > https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=5220bb29
> > 
> > eclass: ros-catkin.eclass: Use cmake-utils_src_make instead of
> > plain emake for src_test so that it works with ninja too.
> > 
> 
> 
> Please try to use short summary lines and put more detailed
> description into the commit message after a newline, also see
> https://wiki.gentoo.org/wiki/Gentoo_git_workflow#Example
> 
> The prefix is also a bit uncommon, see
> https://wiki.gentoo.org/wiki/Gentoo_git_workflow#Commit_message_format

yeah, got that wrong; thx; i tried to remember it as '$dir: message',
which works in all but this case it seems :)

> Ofc, I will expect people to jump in and say "the council hasn't
> decided on that yet", but well... it mostly works fine and is not
> really controversial.

not sure if council approval is needed; uniformity and consistency is
way more important than whatever syntax is used

Reply via email to