>>>>> On Mon, 19 Oct 2015, Anthony G Basile wrote:

> Why can't you just do something like this in the implementation of 
> eapply_user()?  I must be missing some subtle point.

> foo() {
>          if [[ -z $DONE ]]; then
>                  DONE="all done"
>                  echo "in foo"
>          fi
> }

Sure, we could make eapply_user() idempotent in this way. But I'm not
sure if I like adding such magic behaviour.

OTOH, I see that epatch_user() has this:

    # Allow multiple calls to this function; ignore all but the first
    local applied="${T}/epatch_user.log"
    [[ -e ${applied} ]] && return 2

So, suggestion for the spec:

   In EAPIs where it is supported, \t{eapply\_user} must be called
   once in the \t{src\_prepare} phase; for any subsequent calls the
   command will do nothing.

Ulrich

Attachment: pgpl53P9QgQ5l.pgp
Description: PGP signature

Reply via email to