-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 On 10/17/2015 05:52 AM, Ulrich Mueller wrote: >>>>>> On Sat, 17 Oct 2015, hasufell wrote: > >>> 2. eapply_user really belongs in the PM, especially if it's run >>> by default. And it needs patch applying function. And if we >>> have to implement patch applying function anyway, we may as >>> well make it public to avoid unnecessary duplication. > >> Unreliable. The ebuild may define its own src_prepare function > > That eapply_user is called can be enforced by repoman, or by a QA > warning. > >> or the PM might define eapply_user as a no-op, which is valid as >> per PMS. > > Sure, it is implementation defined. Otherwise PMS would have to > specify all the details, e.g. where does the package manager look > for user-supplied patches and how are patch directories organised. > > Ulrich > I'm not sure I follow. What's wrong with supporting env vars like EPATCH_PATH or EPATCH_DIRS, with whatever 'sane default' that the PM in question deems proper? Configuration would be simple and unify any manager that adheres to the spec. If it's implementation-defined, then each package manager would look in a possibly different directory. If we're outlining a spec, imo it would be best to at least establish a common directory so PM authors can rely on it confidently and help avoid user issues.
If I'm missing some detail that doesn't make my idea any good, please tell me. It doesn't seem like trouble from where I'm looking. - -- Daniel Campbell - Gentoo Developer OpenPGP Key: 0x1EA055D6 @ hkp://keys.gnupg.net fpr: AE03 9064 AE00 053C 270C 1DE4 6F7A 9091 1EA0 55D6 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJWJfGgAAoJEAEkDpRQOeFw0f0QAJCRXZMGL5MwQM9LtzF21dYu viytWZPE/tdMIVsDZhmRZ2W4S0lwHq8g8cHhOnA5D2spNKkO8AZ6Litba3Mki91r ks59sd0lqq/Z0lMc1iM/I9i/LkgJ6m5nz4iqdkEqOW+09py2rbHPybG7QmWVg7zW 75roD8qmTQNdnQxPm5W+v2AgJEX475e1Cv+/vPtWOu87AxhfX7k7TlZ3fVd+T6FR rOylk376BEbSnA8rW5eW5lM9NpX6197+5oWxscRhN6SnAyOA/OXAjhl2JAmqX5wO Z7Kc4OVLRQA71swZplwOfloZAbsHB5KRIGuJoc/T/hyXyGI8FEjQYLzd1x8tn9G5 GF02cH223lDNzZyJi0gkgJNITfPWEyN3Vk/jZ5hb0SKCQD37V8eLu/4ophbHTJUE ugFY0576D4qWLiD0H62Orrld5StopXLc8L0/26nkkxEbxfWW9jKGADAxaqVxcrmT ZeCHn5o1LlHhBt1TKVPQ748OmI2WHpzajCzc3rQXJnT3xJI4mASj35RthbKi5n6W 4YJWV4vF7W1WKqSY4Lah+u/68KS1gWNi/oiYoK10GcQHPPygZX1brHQadsPwvbnD 31ssrymXz7nIOZyC6rBPmMwqGaXgq4CZltm4FBQ9IZ+n0NRTEDP0OL6/Lq26c5GZ NLtY//mIUo/hWZavnQ1S =Z99z -----END PGP SIGNATURE-----
