On 01/24/2016 06:29 PM, Aaron W. Swenson wrote:
> Okay, provided that the new USE_EXPAND is okay for POSTGRES_TARGETS,
> attached are the eclasses that I'll commit to the tree.
> 

> case ${EAPI:-0} in
>   0|1|2|3|4) die "postgres-multi.eclass requires EAPI 5 or higher" ;;
>   *) ;;
> esac

Does this really work with EAPI=6? I didn't try, but it looks like it
would need an eapply_user somewhere in src_prepare. And, pedantry
warning, there's no such thing as "EAPI 5 or higher." The lawyers will
tell you to do something like this instead (stolen from git-r3):

  case "${EAPI:-0}" in
          5|6)
                  ;;
          *)
                  die "Unsupported EAPI=${EAPI} (unknown) for ${ECLASS}"
                  ;;
  esac

That will require an edit for every new EAPI, but prevents weird crashes
from things like a missing eapply_user.


Reply via email to