Michał Górny posted on Thu, 26 May 2016 14:08:26 +0200 as excerpted:
> @@ -254,6 +269,15 @@ _git-r3_env_setup() {
> [[ ${!livevar} ]] \
> && ewarn "Using ${livevar}, no support will be provided"
>
> + livevar=${esc_pn}_LIVE_COMMIT_DATE
> + EGIT_COMMIT_DATE=${!livevar-${EGIT_COMMIT_DATE}}
> + [[ ${!livevar} ]] \
> + && ewarn "Using ${livevar}, no support will be provided"
I'd guess that for consistency you want this to be the...
if [[...]]; then
... style that seems to be preferred in this eclass, instead of the bare...
[[...]] &&
... style used here.
(Tho I personally actually prefer the bare [[...]] && style if there's
no else clause, if/then/else to make it explicit if there is. But that's
not what the existing code seems to use, so...)
Meanwhile, in general, I love the idea of having commit date access,
of course with a user override available. I only have a lite kde/plasma
install, but it's all live-9999 packages from the kde overlay and of course
they're all git now, in addition to the pan-9999 ebuild in my overlay as
I'm involved upstream there, so I make a *lot* of use of git-r3 eclass,
and having date override available will definitely help with the occasional
troubleshooting or easy revert to a date I know actually worked! =:^)
--
Duncan - List replies preferred. No HTML msgs.
"Every nonfree program has a lord, a master --
and if you use the program, he is your master." Richard Stallman
