W dniu 12.03.2017, nie o godzinie 12∶35 +0100, użytkownik Alexis Ballier napisał: > On Sun, 12 Mar 2017 12:00:08 +0100 > Michał Górny <[email protected]> wrote: > > > Make the substitution errors in prune_libtool_files logic fatal to > > avoid the dependency of eqawarn. They're extremely unlikely to happen > > anyway. --- > > eclass/eutils.eclass | 7 ++++--- > > 1 file changed, 4 insertions(+), 3 deletions(-) > > > > diff --git a/eclass/eutils.eclass b/eclass/eutils.eclass > > index ab226b236a37..cb472caee1d4 100644 > > --- a/eclass/eutils.eclass > > +++ b/eclass/eutils.eclass > > @@ -982,9 +982,10 @@ prune_libtool_files() { > > for arg in > > ${libs}; do if [[ ${arg} == -l* ]]; then > > if > > [[ ${arg} == '*$*' ]]; then > > - > > eqawarn "${FUNCNAME}: variable substitution likely failed in ${pc}" > > - > > eqawarn "(arg: ${arg})" > > - > > eqawarn "Most likely, you need to add virtual/pkgconfig to DEPEND." > > + > > eerror "${FUNCNAME}: variable substitution likely failed in ${pc}" > > + > > eerror "(arg: ${arg})" > > + > > eerror "Most likely, you need to add virtual/pkgconfig to DEPEND." > > + > > die "${FUNCNAME}: unsubstituted variable found in .pc" fi > > If you go that way then it would be best if this function had a > 'has "virtual/pkgconfig" ${DEPEND} || die ...' kind of logic
You can't reliably query DEPEND in an ebuild. > the message is more intended towards package maintainer and i would > assume they have pkgconfig installed which means the failure will > be on user's throat ...in the extremely unlikely case of not having pkg-config installed. -- Best regards, Michał Górny
signature.asc
Description: This is a digitally signed message part
