On Thu, 29 Jun 2017 14:37:49 -0700 Matt Turner <matts...@gentoo.org> wrote:
> On Thu, Jun 29, 2017 at 2:19 PM, James Le Cuirot <ch...@gentoo.org> wrote: > > On Wed, 28 Jun 2017 23:29:03 +0100 > > James Le Cuirot <ch...@gentoo.org> wrote: > > > >> > On Tue, Jun 27, 2017 at 6:44 PM, James Le Cuirot <ch...@gentoo.org> > >> > wrote: > >> > > I am therefore proposing a new global big-endian flag. This could be > >> > > masked by default and unmasked + forced in the relevant profiles under > >> > > arch. I will apply this according to the mapping defined in tc-endian > >> > > of > >> > > toolchain-funcs.eclass. > >> > >> I've just been putting the patch together. I made it slightly simpler > >> by masking *and* forcing it by default so that it only needs to be > >> unmasked were necessary. > > > > Feedback seems positive so here is the patch. I'll apply it late next > > week as I don't need it immediately and I will be away until then. > > > > --- > > > > diff --git a/profiles/arch/alpha/use.mask b/profiles/arch/alpha/use.mask > > index d488fe8a09f4..b17afe9d9d4d 100644 > > --- a/profiles/arch/alpha/use.mask > > +++ b/profiles/arch/alpha/use.mask > > @@ -1,6 +1,10 @@ > > # Copyright 1999-2017 Gentoo Foundation. > > # Distributed under the terms of the GNU General Public License, v2 > > > > +# James Le Cuirot <ch...@gentoo.org> (29 Jun 2017) > > +# Unmask as this profile is big endian. > > +-big-endian > > No. Alpha is little endian. Wikipedia says it is bi. tc-native() reports alpha* as big so I guess that's the only variant we support? Then again, this page says it is usually little. Is tc-native() wrong? https://kernelnewbies.org/EndianIssues > > --- /dev/null > > +++ b/profiles/arch/mips/mipsel/use.mask > > @@ -0,0 +1,6 @@ > > +# Copyright 1999-2017 Gentoo Foundation > > +# Distributed under the terms of the GNU General Public License v2 > > + > > +# James Le Cuirot <ch...@gentoo.org> (29 Jun 2017) > > +# Remask as this profile is little endian. > > +big-endian > > diff --git a/profiles/arch/mips/use.mask b/profiles/arch/mips/use.mask > > index 09ac8ca4b2cc..6caff81617cb 100644 > > --- a/profiles/arch/mips/use.mask > > +++ b/profiles/arch/mips/use.mask > > @@ -4,6 +4,10 @@ > > # Unmask the flag which corresponds to ARCH. > > -mips > > > > +# James Le Cuirot <ch...@gentoo.org> (29 Jun 2017) > > +# Unmask as this profile is big endian. > > +-big-endian > > I'm not sure if this one is correct. arch/mips/mipsel's 'parent' file > contains '..' > > I think if you re-mask big-endian in arch/mips/mipsel it'll work, and > that seems like the best way to solve it. That's what I did?
pgpusFUoTbJJb.pgp
Description: OpenPGP digital signature
