>>>>> On Fri, 8 Sep 2017, Ciaran McCreesh wrote: > On Fri, 08 Sep 2017 14:54:10 +0200 > Michał Górny <[email protected]> wrote: >> It only explains how the functions parse stuff (except for ver_test >> which uses PMS rules). They are by definition supposed to work with >> random upstream versions.
> This sounds like the sort of thing that could go horribly wrong... > I didn't design versionator to work with arbitrary messy stuff since > the main use is in manipulating Gentoo PV versions. If we would strictly follow PMS wording there, then for _alpha, _beta, _p, etc. the underscore would be part of the component. Also in a suffix like _p2, _p and 2 would be separate components. However, with versionator.eclass: get_version_components 3.0_p2 -> 3 0 p2 So even there, the underscore is taken as a separator. I don't say that this behaviour is bad, only that it doesn't strictly follow PMS rules. > Where are these other versions coming from? They occur as output of those functions, and I think that e.g. splitting 1.2_rc3 into components "1", "2", "rc", and "3" with separators ".", "_", and "" makes more sense than treating "_rc" as an atomic block. Ulrich
pgp5MBdlalyKO.pgp
Description: PGP signature
