>>>>> On Sun, 5 Nov 2017, Patrice Clement wrote: > ACK. This code has been there for ages and I also don't think it makes sense > to > keep it as it seems these operations are handled by Portage already. Mike > (floppym) suggested to remove the whole if clause and call fperms instead:
> diff --git a/eclass/vim-plugin.eclass b/eclass/vim-plugin.eclass
> index abe9c7b3661..46908bb73e6 100644
> --- a/eclass/vim-plugin.eclass
> +++ b/eclass/vim-plugin.eclass
> @@ -35,19 +35,6 @@ vim-plugin_src_install() {
> has "${EAPI:-0}" 0 1 2 && ! use prefix && ED="${D}"
> local f
> - if use !prefix && [[ ${EUID} -eq 0 ]] ; then
> - ebegin "Fixing file permissions"
> - # Make sure perms are good
> - chmod -R a+rX "${S}" || die "chmod failed"
> - find "${S}" -user 'portage' -exec chown root '{}' \; || die
> "chown failed"
> - if use userland_BSD || [[ ${CHOST} == *-darwin* ]] ; then
> - find "${S}" -group 'portage' -exec chgrp wheel '{}'
> \; || die "chgrp failed"
> - else
> - find "${S}" -group 'portage' -exec chgrp root '{}' \;
> || die "chgrp failed"
> - fi
> - eend $?
> - fi
> -
> # When globbing, if nothing exists, the shell literally returns the
> glob
> # pattern. So turn on nullglob and extglob options to avoid this.
> eshopts_push -s extglob
> @@ -86,7 +73,7 @@ vim-plugin_src_install() {
> "couldn't move ${S} to ${ED}/usr/share/vim/vimfiles"
> # Fix remaining bad permissions
> - chmod -R -x+X "${ED}"/usr/share/vim/vimfiles/ || die "chmod failed"
> + fperms -R a+rX /usr/share/vim/vimfiles
> }
LGTM (assuming that a+rX are the intended permissions).
Ulrich
pgpiKTrqOqLSE.pgp
Description: PGP signature
