On Sun, 2018-01-21 at 00:26 +0000, Sergei Trofimovich wrote: > Fixes build failures in unprivileged containers like bug #645182: > Package: dev-python/pycparser-2.14 > >>> Unpacking source... > tar: CHANGES: Cannot change ownership to uid 1000, gid 1000: > Invalid argument > > In such containers uid=0 can't really change file ownership. > > Closes: https://bugs.gentoo.org/645182 > Signed-off-by: Sergei Trofimovich <sly...@gentoo.org> > --- > eclass/vcs-snapshot.eclass | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/eclass/vcs-snapshot.eclass b/eclass/vcs-snapshot.eclass > index 3eff6995fae..2b3f73897ce 100644 > --- a/eclass/vcs-snapshot.eclass > +++ b/eclass/vcs-snapshot.eclass > @@ -67,7 +67,8 @@ vcs-snapshot_src_unpack() { > # XXX: check whether the directory > structure inside is > # fine? i.e. if the tarball has > actually a parent dir. > mkdir "${destdir}" || die > - tar -C "${destdir}" -x --strip- > components 1 \ > + # -o (--no-same-owner) to avoid > restoring original owner > + tar -C "${destdir}" -x -o --strip- > components 1 \ > -f "${DISTDIR}/${f}" || die > ;; > *)
Also, ultra-bikeshed: I think using "Signed-off-by" with yourself in it is generally frowned upon and adds no real value.
