On Thu, 08 Feb 2018 16:51:52 +0200
Mart Raudsepp <l...@gentoo.org> wrote:

> On Thu, 2018-02-08 at 14:57 +0100, Michael Lienhardt wrote:
> > > >  From e590965cdeb0c921194740da0481c85afaa1ebae Mon Sep 17
> > > > 00:00:00 2001
> > > > From: Matt Turner <matts...@gentoo.org>
> > > > Date: Tue, 6 Feb 2018 14:02:59 -0800
> > > > Subject: x11-base/xorg-server: Remove dead x11-
> > > > proto/xf86rushproto dependency
> > > > 
> > > > rushproto hasn't been required since upstream commit
> > > > 8ec79e05feac (in
> > > > 2005!), and even then it wasn't actually needed!
> > > > 
> > > > Package-Manager: Portage-2.3.19, Repoman-2.3.6
> > > > ---
> > > >   x11-base/xorg-server/xorg-server-1.19.5.ebuild | 3 +--
> > > >   x11-base/xorg-server/xorg-server-1.19.6.ebuild | 3 +--
> > > >   x11-base/xorg-server/xorg-server-9999.ebuild   | 3 +--
> > > >   3 files changed, 3 insertions(+), 6 deletions(-)
> > > >   
> > > 
> > > Please don't edit dependencies in-line like this.
> > > 
> > > This warranted a revbump as users will be asking how to remove
> > > x11-proto/xf86rushproto. It won't come up for depclean because of
> > > xorg-server not being scheduled for rebuild automatically until
> > > the next
> > > time it is upgraded or --changed-deps option is used (uncommon).
> > > 
> > > Brian  
> > 
> > Citing Kenneth Hoste at FOSDEM this year: modifying a package
> > without changing its version is a bad idea.
> > His presentation was very good (video included):
> > https://fosdem.org/2
> > 018/schedule/event/how_to_make_package_managers_cry/ 
> 
> This isn't so clear cut simple. We build from source at user systems.
> Think of the effect for something like webkit-gtk, chromium,
> libreoffice, etc.

Exactly and while this package isn't as big as those, it could be
argued that xorg-server is bumped frequently enough that the lingering
dependency would have been flushed out soon enough anyway. It's not
like it's doing any harm.

I also think that FOSDEM talk was making a different point, aimed at
upstreams in order to help packagers rather than packagers themselves.

-- 
James Le Cuirot (chewi)
Gentoo Linux Developer

Reply via email to