On Tue, Jun 05, 2018 at 11:24:49PM +0200, Andreas K. Huettel wrote: > Am Sonntag, 3. Juni 2018, 03:47:14 CEST schrieb Marty E. Plummer: > > In the live ebuilds using this eclass, the git logic is handled in the > > ebuild itself and not the eclass. Drop the git logic as it uses git-2 > > which has been deprecated for quite some time. > > > > Marty E. Plummer (2): > > toolchain-binutils.eclass: drop git-2 > > toolchain-glibc.eclass: remove git logic > > > > eclass/toolchain-binutils.eclass | 16 +--------------- > > eclass/toolchain-glibc.eclass | 11 +---------- > > 2 files changed, 2 insertions(+), 25 deletions(-) > > As already discussed in private, this doesnt really make sense... > > Both eclasses are only used in old, stable ebuilds that are being phased out, > and are in freeze. > > Reason I sent these patches is git-2 is deprecated in favor of git-r3, and I assume (perhaps wrongly) git-2.eclass won't be removed from the tree untill all its consumers are ported.
And in both eclasses the ebuilds which use them never enter the git logic path, so its effectively dead code and even with the 'freeze' this change will not change their behavior. > -- > Andreas K. H?ttel > [email protected] > Gentoo Linux developer > (council, toolchain, perl, libreoffice, comrel)
