On Wed, Jun 20, 2018 at 11:33:53PM +0100, James Le Cuirot wrote: > On Wed, 20 Jun 2018 17:21:09 -0500 > "Marty E. Plummer" <[email protected]> wrote: > > > On Wed, Jun 20, 2018 at 09:03:44PM +0800, Jason Zaman wrote: > > > On Wed, Jun 20, 2018 at 02:10:50AM -0500, Marty E. Plummer wrote: > > > > Use ${EROOT%/} whereever possible, as the tools and directories which > > > > are used with it are already prefixed with a / > > > > > > > > Package-Manager: Portage-2.3.40, Repoman-2.3.9 > > > > --- > > > > eclass/xdg-utils.eclass | 10 +++++----- > > > > 1 file changed, 5 insertions(+), 5 deletions(-) > > > > > > > > diff --git a/eclass/xdg-utils.eclass b/eclass/xdg-utils.eclass > > > > index ac075185d8e..8dba5ed6861 100644 > > > > --- a/eclass/xdg-utils.eclass > > > > +++ b/eclass/xdg-utils.eclass > > > > @@ -66,7 +66,7 @@ xdg_environment_reset() { > > > > # Updates the .desktop files database. > > > > # Generates a list of mimetypes linked to applications that can handle > > > > them > > > > xdg_desktop_database_update() { > > > > - local updater="${EROOT}${DESKTOP_DATABASE_UPDATE_BIN}" > > > > + local updater="${EROOT%/}${DESKTOP_DATABASE_UPDATE_BIN}" > > > > > > Shouldn't things like this be $BROOT since they're being run? $EROOT > > > might be a different architecture that may or may not run at all on the > > > build machine. > > > > > Good point, but here's a question; if EROOT=${ROOT%/}${EPREFIX}, how do > > we use BROOT here? EBROOT? Or longhand ${BROOT%/}${EPREFIX} ? I think > > that may be a use case that got missed in the EAPI 7 discussions. > > BROOT is already prefixed as BROOT without a prefix would just be /. > I don't follow. Its my understanding that BROOT ~= ROOT for most situations. But consider this setup: Ubuntu amd64 with Gentoo Prefix, emerging a native arm @system to /mnt/arm EPREFIX = /home/user/gentoo.
In this situation, ROOT=/mnt/arm, EROOT=/mnt/arm, but what is BROOT? /, or /home/usr/gentoo? > -- > James Le Cuirot (chewi) > Gentoo Linux Developer
