On Sat, Aug 25, 2018 at 10:11 PM Andrew Savchenko <[email protected]> wrote: > > On Sat, 25 Aug 2018 14:24:02 -0400 Mike Gilbert wrote: > > PMS does not specify that behavior (skipping src_test with USE=-test). > > It is better to define the requrement explicitly rather than relying > > on a Portage-specific behavior. > > Then PMS should be fixed. Putting useless code in thousands > of ebuilds due to bureaucratic reasons is ridiculous. Having strict > conformance to the PMS is good, but common sense should still be > considered.
I disagree with your opinion. Adding one line of code to many ebuilds is not a crazy idea, and it doesn't need to happen overnight. Adding RESTRICT="!test? ( test )" is certainly not harmful. The advice given in the devmanual should agree with PMS. I think PMS is unlikely to change; if it does, the devmanual can be updated to match. Personally, I would not like to see a change in PMS in this regard. I think controlling tests via USE conditionals in RESTRICT is a nice way to avoid hard-coding the meaning of individual USE flags into PMS. It also gives the ebuild author more flexibility. For example, he could put something like this in RESTRICT if some exotic "foo" feature causes tests to fail: RESTRICT="foo ( test )"
