On Fri, 14 Sep 2018 23:15:28 +0300 Alon Bar-Lev <alo...@gentoo.org> wrote:
> > > > Unused variable is a good example of typical benign warning: > > > > it was there all the time, it's not a new bug and does not > > > > warrant need for an immediate fix. > > > > > > Unused variable is a good example of CRITICAL potential issue > > > > I understand you point. I disagree with it. > > > > My litmus test: if behaviour of the package did not change after > > the fix then the issue was not real. > > But how can you get the report to evaluate if it is real or not? You don't. You don't get a report until user explicitly asks for it or encounters real bug. I would follow the same model Gentoo does for FEATURES=test and FEATURES=strict/stricter. If people like reporting build or test issues and have enough time for it they will enable the flag. > while we are looking for the trigger to evaluate. My take on it: we are not looking for them on every users' machine and it's ok to miss bugs and false positives as a result. -- Sergei
