On 11/01/2018 06:27 PM, Andrew Savchenko wrote: > > This eclass is small, so no harm here. But for larger eclasses > (hello java-*.eclass) this will hinder updates considerably. I > prefer to fix something rather than to fix nothing while > frustrating in attempt to fix everything at once. > > Also this make git history review harder as fixes for independent > issues will be mixed together. > > So I kindly ask you for future updates (from everyone, not just > me) focus on review of the proposed changes instead of reviewing > full code. Thank you for understanding. >
You don't have to fix everything at once. A thorough code review is incredibly valuable we shouldn't discourage anyone from doing them. On the other hand, if you decide to fix only some of the issues, that's your prerogative. I would however suggest that afterwards, you open a bug for the remaining improvements so that the valuable time of the reviewer is not wasted.
