On Thu, 2019-06-13 at 09:01 -0400, Michael Orlitzky wrote:
> On 6/13/19 1:33 AM, Michał Górny wrote:
> > > > + eshell=$(user_get_nologin)
> > >
> > > Then this would have to become
> > >
> > > eshell=$(userland_get_nologin "${USERLAND}")
> >
> > Do you have any real use for that?
> >
>
> No. It's a better design IMO since you can e.g. test the function by
> passing it an argument rather than by setting a global variable (which
> has other consequences). But no immediate application.
> I'm sorry but this makes no sense. The function already depends on ROOT variable, and on presence of specific files in the filesystem. I see no reason to make USERLAND special here. Furthermore, it's an internal function with no external application. It has two call sites, and in both we want the same value of USERLAND (which is defined by profiles) to apply. -- Best regards, Michał Górny
signature.asc
Description: This is a digitally signed message part
