On 2019-08-03 18:20, Ulrich Mueller wrote: >>>>>> On Sat, 03 Aug 2019, Thomas Deutschmann wrote: > >> +# @ECLASS-VARIABLE: _SAVEDCONFIG_CONFIGURATION_FILE > > 31 chars? Seems excessive for a name of a private variable.
And? I'll keep that name for readability instead of finding an
abbreviation.
>> +# Restores the configuration saved ebuild previously potentially with user
>> edits.
>
> If have trouble understanding this sentence.
v2 will contain a better sentence.
>> + if [[ -r "${configfile}" ]] ; then
>
> Quotes are not necessary here.
Not necessary but it won't hurt. I'd like to keep them for style. I.e. I
think it's better to always quote so you won't forget when it will
become critical.
--
Regards,
Thomas Deutschmann / Gentoo Linux Developer
C4DD 695F A713 8F24 2AA1 5638 5849 7EE5 1D5D 74A5
signature.asc
Description: OpenPGP digital signature
