On Wed, 2019-11-27 at 11:04 +0100, Ulrich Mueller wrote: > > > > > > On Wed, 27 Nov 2019, Michał Górny wrote: > > Update the skel variable order to place S immediately after SRC_URI. > > This seems to be a growing trend, and is quite reasonable given that > > S usually matches the archive name, and e.g. if SRC_URI uses MY_P, > > then S usually uses it as well: > > SRC_URI="http://example.com/${MY_P}.tar.gz"; > > S=${WORKDIR}/${MY_P} > > My only concern is that this doesn't match the grouping of variables > in PMS. All other variables in these first blocks are ebuild-defined > variables [1], whereas S is not.
To be honest, I never even realized this was the thing so far. I honestly doubt it makes much real difference to anyone, though, and the alternative has practical advantage of keeping relevant variables closer. > [1] https://projects.gentoo.org/pms/7/pms.html#x1-590007 -- Best regards, Michał Górny
signature.asc
Description: This is a digitally signed message part
