On Fri, 06 Dec 2019 16:16:32 -0800 Georgy Yakovlev <[email protected]> wrote:
> On Friday, December 6, 2019 3:44:38 PM PST Sergei Trofimovich wrote: > > On Fri, 6 Dec 2019 12:09:31 -0800 > > > > Georgy Yakovlev <[email protected]> wrote: > > > Default output just prints crate name. > > > With -vv we can see all cargo options and rustc args. > > > > > > Signed-off-by: Georgy Yakovlev <[email protected]> > > > --- > > > > Looks good! > > > > I had to do an equivalent locally at least a few times. > Pushed! > > > > While at it I also suggest adding equivalent of > > econf's/emake's ${EXTRA_ECONF} and ${EXTRA_EMAKE} > > to allow users to inject arbitrary stuff. For example > > to sneak in '-Z' options globally. > > > > Say, ${CARGO_BUILD_EXTRA}, ${CARGO_INSTALL_EXTRA}, > > ${CARGO_TEST_EXTRA}. > > > > Yeah, it's on my to-do list for this eclass. > 1 question tho, should it come after "$@" or before? Do you use it? > I know cargo can be picky about order and some ebuilds rely on passing params > in phase funcs. I don't use it frequently for carge.eclass but use it extensively for ./configure and haskell-cabal.eclass. I'd say variables are designed to override everything else (eclass defaults and ebuild values) and thus should come after "$@": econf() { ... "$@" "${EXTRA_ECONF[@]}" } ${MAKE:-make} ${MAKEOPTS} "$@" ${EXTRA_EMAKE} -- Sergei
