On 8/1/20 4:25 PM, Michał Górny wrote:
> On Sat, 2020-08-01 at 14:32 -0400, Adam Feldman wrote:
>> Whenever package doesn't have static-libs available and selected,
>> if configure script has static-libs selectable, explicitly disable
>>
>> Bug: https://bugs.gentoo.org/695878
>> ---
>>  eclass/mate.eclass | 12 +++++++++++-
>>  1 file changed, 11 insertions(+), 1 deletion(-)
>>
>> diff --git a/eclass/mate.eclass b/eclass/mate.eclass
>> index db511aedb1f1..d6718872c05d 100644
>> --- a/eclass/mate.eclass
>> +++ b/eclass/mate.eclass
>> @@ -115,7 +115,17 @@ mate_src_prepare() {
>>  # MATE specific configure handling
>>  # Stub to gnome2_src_configure()
>>  mate_src_configure() {
>> -    gnome2_src_configure "$@"
>> +
>> +    local mateconf=()
>> +
>> +    # Pass --disable-static whenever possible
>> +    if ! use_if_iuse static-libs; then
>> +            if grep -q "enable-static" "${ECONF_SOURCE:-.}"/configure; then
>> +                    mateconf+=( --disable-static )
>> +            fi
>> +    fi
>> +
>> +    gnome2_src_configure ${mateconf[@]} "$@"
> 
> "${mateconf[@]}".  Using [@] without quoting makes no sense, and I'm
> sure linters will complain.
> 
>>  }
>>  
>>  # @FUNCTION: mate_src_install
> 

Fixed.  Thanks for the review.

-- 
Thanks,

Adam Feldman
Gentoo Developer
np-hard...@gentoo.org
0x671C52F118F89C67

Attachment: signature.asc
Description: OpenPGP digital signature

Reply via email to