Marek Szuba schrieb am 30.09.20 um 18:23: > Same as lua.eclass and python-r1, this is a Lua version of > python-single-r1. Setting LUA_SINGLE_TARGETS allows one to choose the > (slotted) Lua implementation to build your ebuild against, optionally > including both single- and multi-implementation Lua packages as > dependencies. >
Hello Marek! First of all thank you very much for your work on the eclasses supporting slotted lua. It is very much appreciated. As I am not really capable of doing a review I took your eclasses and tried to use it for app-admin/conky (using lua-single) where new versions already need at least lua-5.2. See the changes below. I already had slotted lua 5.1 and 5.3 installed and the modified ebuild built fine with lua-5.3 as before. However when I tried setting LUA_SINGLE_TARGET="lua5-2", lua-5.2 was pulled in as a dependency but conky still built against lua-5.3. The temporary pkg-config environment was set correct but somehow it seems not used. Conky uses cmake and pkg_search_module [1] to detect lua preferring 5.3 over 5.2. Am I doing something wrong using the eclass or is there an issue with the lua detection in conky or maybe the the eclass? [1] https://github.com/brndnmtthws/conky/blob/master/cmake/ConkyPlatformChecks.cmake --- conky-1.11.6.ebuild 2020-09-21 12:32:10.180949870 +0200 +++ conky-1.11.6-r1.ebuild 2020-10-01 00:04:13.099147223 +0200 @@ -3,7 +3,9 @@ EAPI=7 -inherit cmake linux-info readme.gentoo-r1 xdg +LUA_COMPAT=( lua5-{2..3} ) + +inherit cmake linux-info lua-single readme.gentoo-r1 xdg DESCRIPTION="An advanced, highly configurable system monitor for X" HOMEPAGE="https://github.com/brndnmtthws/conky"; @@ -45,7 +47,7 @@ weather-metar? ( net-misc/curl ) webserver? ( net-libs/libmicrohttpd ) xmms2? ( media-sound/xmms2 ) - || ( dev-lang/lua:5.3 dev-lang/lua:5.2 ) + ${LUA_DEPS} " RDEPEND=" ${COMMON_DEPEND} @@ -85,6 +87,8 @@ pkg_setup() { use ipv6 && linux-info_pkg_setup + + lua-single_pkg_setup } src_prepare() { -- -- Daniel Pielmeier
