On Thu, Jun 24, 2021 at 12:51 PM Ulrich Mueller <[email protected]> wrote:
> >>>>> On Thu, 24 Jun 2021, David Michael wrote:
> > --- a/eclass/ninja-utils.eclass
> > +++ b/eclass/ninja-utils.eclass
> > @@ -1,4 +1,4 @@
> > -# Copyright 1999-2018 Gentoo Foundation
> > +# Copyright 1999-2021 Gentoo Foundation
>
> Please update to "Gentoo Authors".
>
> >  # Distributed under the terms of the GNU General Public License v2
> >
> >  # @ECLASS: ninja-utils.eclass
> > @@ -8,7 +8,7 @@
> >  # @AUTHOR:
> >  # Michał Górny <[email protected]>
> >  # Mike Gilbert <[email protected]>
> > -# @SUPPORTED_EAPIS: 2 4 5 6 7
> > +# @SUPPORTED_EAPIS: 5 6 7 8
> >  # @BLURB: common bits to run dev-util/ninja builder
> >  # @DESCRIPTION:
> >  # This eclass provides a single function -- eninja -- that can be used
> > @@ -21,10 +21,8 @@
> >  if [[ -z ${_NINJA_UTILS_ECLASS} ]]; then
> >
> >  case ${EAPI:-0} in
>
> This could be simplified to "case ${EAPI} in".

Okay, I've updated https://github.com/gentoo/gentoo/pull/21409 and
also moved the EAPI check outside the inherit guard, since that's what
other eclasses seem to do.

Thanks.

David

Reply via email to