> May be worth splitting the commit into a few different changes > so the summary can be more informative than "fixes" > (try git add -p).
Actually the more accurate summary would be "fix dune-install function". I wouldn't split it imo. On 12/9/21 23:29, Sam James wrote:
On 9 Dec 2021, at 22:10, Maciej Barć <[email protected]> wrote: bump to EAPI 8Say "support EAPI 8" instead. May be worth splitting the commit into a few different changes so the summary can be more informative than "fixes" (try git add -p). lgtm otherwise, thanks for doing this!drop support for EAPI 5 set DUNE_PKG_NAME to PN by default move "Move docs to the appropriate place" block to dune-install to make dune-install now handle a list of subpackages correctly Signed-off-by: Maciej Barć <[email protected]> --- eclass/dune.eclass | 50 ++++++++++++++++++++++++++++------------------ 1 file changed, 31 insertions(+), 19 deletions(-) [snip]Best, sam
-- Have a great day! ~ Maciej XGQT Barć
OpenPGP_0x14D74A1F43A6AC3C.asc
Description: OpenPGP public key
OpenPGP_signature
Description: OpenPGP digital signature
