>>>>> On Wed, 16 Feb 2022, Mart Raudsepp wrote: > Ühel kenal päeval, K, 16.02.2022 kell 19:39, kirjutas Ulrich Müller: >> Function vala_src_prepare did not call eapply_user, so it could not >> be >> used as a stand-alone phase function but must be called explicitly. >> Rename it to vala_setup, which can be called either from pkg_setup or >> from src_prepare.
> Just to clarify the reasons to drop the EXPORT - it's really about the > fact that you can actually never use it automatically. Absolutely all > packages that use vala.eclass need to define their own src_prepare in > the ebuild anyways, in order to also call gnome_src_prepare, > cmake_src_prepare, or xdg_src_prepare. > So the exported phase had no value, as an ebuild author always needs to > declare their own, so it's just confusing with the vala_src_prepare > function naming from before. I wonder if we should drop the export retroactively. EAPIs 6 and 7 require eapply_user, so if src_prepare is vala_src_prepare then it will always result in an error. Or am I missing something? Ulrich
signature.asc
Description: PGP signature
